Java Split Text File Into Pages Based on Form Feed

2 Answers 2

\$\begingroup\$

I don't think that using : is a bad practice but you have to escape it somehow if it occurs inside your data. Anyway, I'd consider using XML or JSON here.

Some notes about the code:

1. You should close the stream (in a finally block). See Guideline 1-2: Release resources in all cases in Secure Coding Guidelines for the Java Programming Language
2. The .ser file extension is often used for serialized Java objects. I'd use something else to avoid the possible confusion.

3. It's a good practice to set the character set when you read a text file. The used FileReader always uses the default charset which could vary from system to system. Consider using InputStreamReader and FileInputStream as the documentation of FileReader says. Here is an example:

                       FileInputStream fileInputStream = null; InputStreamReader inputStreamReader = null; BufferedReader bufferedReader = null; try {     fileInputStream = new FileInputStream("people.dat");     inputStreamReader = new InputStreamReader(fileInputStream, "UTF-8");     bufferedReader = new BufferedReader(inputStreamReader);      // use BufferedReader here } finally {     IOUtils.closeQuietly(bufferedReader);     IOUtils.closeQuietly(inputStreamReader);     IOUtils.closeQuietly(fileInputStream); }                                      

   It uses IOUtils from Apache Commons IO and closes the FileInputStream even if the constructor of InputStreamReader or BufferedReader throws an exception.

answered Aug 26, 2012 at 0:58

palacsintpalacsint

29.8k 9 gold badges 79 silver badges 156 bronze badges

\$\endgroup\$

6

• \$\begingroup\$ How would I do number 3? \$\endgroup\$

  Aug 26, 2012 at 1:19

• \$\begingroup\$ @KyelJmD: See the edit, please. \$\endgroup\$

  Aug 26, 2012 at 1:27

• \$\begingroup\$ why did you use final? \$\endgroup\$

  Aug 26, 2012 at 5:39

• \$\begingroup\$ @KyelJmD: final helps readers and maintainers, because they know that the reference always points to the same instance and it doesn't change later. programmers.stackexchange.com/questions/115690/… but you can find other questions on Programmers.SE in the topic. \$\endgroup\$

  Aug 26, 2012 at 8:46

• \$\begingroup\$ I would place those final variables in the class? or inside a method that calls them? \$\endgroup\$

  Aug 26, 2012 at 9:50

\$\begingroup\$

Scanner is a bit easier to use then BufferedReader...

                import java.io.File; import java.io.FileNotFoundException; import java.util.ArrayList; import java.util.List; import java.util.Scanner;   public class Main {      public static void main(String[] args) {                 try {             File f = new File("people.ser");             Scanner sc = new Scanner(f);              List<Person> people = new ArrayList<Person>();              while(sc.hasNextLine()){                 String line = sc.nextLine();                 String[] details = line.split(":");                 String gender = details[0];                 String name = details[1];                 int age = Integer.parseInt(details[2]);                 Person p = new Person(gender, name, age);                 people.add(p);             }              for(Person p: people){                 System.out.println(p.toString());             }          } catch (FileNotFoundException e) {                      e.printStackTrace();         }     } }  class Person{      private String gender;     private String name;     private int age;      public Person(String gender, String name, int age){         this.gender = gender;         this.setName(name);         this.age = age;     }      /**      * @return the gender      */ public String getGender() {     return gender; }  /**  * @param gender the gender to set  */ public void setGender(String gender) {     this.gender = gender; }  /**  * @param name the name to set  */ public void setName(String name) {     this.name = name; }  /**  * @return the name  */ public String getName() {     return name; }  /**  * @return the age  */ public int getAge() {     return age; }  /**  * @param age the age to set  */ public void setAge(int age) {     this.age = age; }  public String toString(){     return this.gender + " " + this.name + " " + this.age; }   }                              

answered Sep 1, 2012 at 1:20

\$\endgroup\$

2

• \$\begingroup\$ toString() method should use StringBuilder instead of concatenation. \$\endgroup\$

  Jan 17, 2013 at 0:39

• \$\begingroup\$ Since the toString() method is likely only used for debugging purposes, I'd say readability trumps performance here and the current implementation is a lot more readable. In case it is used in heavy iteration, that might be a different case. \$\endgroup\$

  Nov 25, 2014 at 9:02

hicksfrottive.blogspot.com

Source: https://codereview.stackexchange.com/questions/15062/reading-a-line-from-a-text-file-and-splitting-its-contents

Share this post